<html>
<head><meta charset="utf-8"><title>making dataflow public · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html">making dataflow public</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="175855013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/175855013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#175855013">(Sep 16 2019 at 21:36)</a>:</h4>
<p>can someone familiar with dataflow comment on whether it's ok to be made public for clippy?<br>
see: <a href="https://github.com/rust-lang/rust/pull/64207" target="_blank" title="https://github.com/rust-lang/rust/pull/64207">https://github.com/rust-lang/rust/pull/64207</a></p>



<a name="175855039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/175855039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#175855039">(Sep 16 2019 at 21:36)</a>:</h4>
<p>I've done some work on it and think it's fine, but wanted a second opinion</p>



<a name="175856655"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/175856655" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#175856655">(Sep 16 2019 at 21:57)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="119009">@eddyb</span></p>



<a name="175860550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/175860550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#175860550">(Sep 16 2019 at 22:58)</a>:</h4>
<p>Just a heads up, <a href="https://github.com/rust-lang/rust/issues/64470" target="_blank" title="https://github.com/rust-lang/rust/issues/64470">#64470</a> contains a more generic dataflow analysis engine needed for const qualification, and I'm planning to make the current one a special-case of that one. I should be able to stay compatible with consumers of the old API though. Also, can we keep <code>state_for_location</code> private? It makes it too easy to accidentally go quadratic IMO.</p>



<a name="175868946"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/175868946" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#175868946">(Sep 17 2019 at 01:43)</a>:</h4>
<p>See <a href="https://github.com/rust-lang/rust/issues/64532" target="_blank" title="https://github.com/rust-lang/rust/issues/64532">#64532</a></p>



<a name="176300624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/176300624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> gnzlbg <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#176300624">(Sep 22 2019 at 08:24)</a>:</h4>
<p><span class="user-mention" data-user-id="118594">@ecstatic-morse</span> FWIW you don't need to stay compatible with the old API</p>



<a name="176300625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/176300625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> gnzlbg <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#176300625">(Sep 22 2019 at 08:24)</a>:</h4>
<p>if you change the API, clippy fails to compile, and they'll have to upgrade to the new API</p>



<a name="176300682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/making%20dataflow%20public/near/176300682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> gnzlbg <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/making.20dataflow.20public.html#176300682">(Sep 22 2019 at 08:26)</a>:</h4>
<p>right now clippy is not using it, so maybe consider these type of users for the new API ? (I find the new one much better than the old one, mainly because it is much better documented)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>